ac83dad

src/net/bowmap/server/logic.clj modified (view file)

@@ -9,8 +9,6 @@   (fn [fact]     (::fact/id fact))) -; TODO see the comment on responses.clj-; But this is also being called within a transaction and assuming that so I'm not sure (defmethod handler ::fact/server-list-requested [fact]   (let [{:keys! [::client/client]} fact]     [{::response/id ::response/send-server-list@@ -24,5 +22,8 @@                              :enforcesSecureChat false}}]))  ; Returns a seq of responses+; And document that this is not called synchronously (hence the transactions as well) (defn handle-fact [fact]-  (handler fact))+  ; TODO I think this is fine because it has to be run within a transaction anyway?+  ; All though I suppose not all fact handling needs to be in a transaction some is trivial so idk.+  (dosync (handler fact)))

src/net/bowmap/stormbow/responses.clj modified (view file)

@@ -16,6 +16,9 @@ ; TODO currently this must always happen within a transaction, but that's no good! ; This is being called _always_ synchronously from the packet handler, which is also no good for even more reasons ; So, figure out how to not do that?++; This method works outside of a transaction, but it's being passed the client _value_+; The client value may well have changed since this method was called (defmethod handle-response! ::response/send-server-list [response]   (let [{:keys! [::client/client server-list-response]} response         {:keys! [::state/connection-state ::connection/connection]} client